linux-kernel - Re: [PATCH 0/3] PCI: Rework config space locking, add INTx masking services

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Oct 2011 14:32:03 +0200
From:	Jan Kiszka <jan.kiszka@...mens.com>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
CC:	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Hans J. Koch" <hjk@...sjkoch.de>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	Brian King <brking@...ux.vnet.ibm.com>
Subject: Re: [PATCH 0/3] PCI: Rework config space locking, add INTx masking
 services

On 2011-10-14 16:48, Jan Kiszka wrote:
> On 2011-10-06 17:48, Jesse Barnes wrote:
>> On Mon, 12 Sep 2011 18:54:01 +0200
>> Jan Kiszka <jan.kiszka@...mens.com> wrote:
>>
>>> This series tries to heal the currently broken locking scheme around PCI
>>> config space accesses.
>>>
>>> We have an interface lock out access via sysfs, but that service wrongly
>>> assumes it is only called by one instance at a time for some device. So
>>> two loops doing
>>>
>>> echo 1 > /sys/bus/pci/devices/<some-device>/reset
>>>
>>> in parallel will trigger a kernel BUG at the moment.
>>>
>>> Besides synchronizing with user space, we also need to manage config
>>> space access of generic PCI drivers. They need to mask legacy interrupt
>>> lines while the specific driver runs in user space or a guest OS.
>>>
>>> The approach taken here is provide mutex-like locking for general
>>> access - which still requires a special mechanism due to requirements of
>>> the IBM Power RAID SCSI driver. Furthermore, INTx masking is now
>>> available via the PCI core and synchronized via the internal pci_lock.
>>>
>>> Not sure who may want to take this, so I'm CC'ing broadly.
>>
>> ISTR a bunch of discussion about this (just back from lots of work
>> travel and vacation, sorry I missed most of it).
>>
>> Is this the agreed upon way of handling it?  If so, can I get some
>> Reviewed/Acked-bys from people?
> 
> I hope this is acceptable. These changes are required for further
> improvements of the KVM device assignment support (INTx sharing). So I
> would appreciate any ack or whatever feedback as well.

At least two acks arrived by now. But I guess this series is not yet
lined up for the 3.2 window, is it? Can we get it merged for 3.3? Just
let me know if any rebasing is required and against which tree.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/