linux-kernel - Re: [PATCH] irq: don't put module.h into irq.h for tracking irqgen modules.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOesGMgGKowZa8fZOw5hMG8_u9TYJzoQBfJtfvghEwpxXTgyow@mail.gmail.com>
Date:	Tue, 25 Oct 2011 14:58:08 -0700
From:	Olof Johansson <olof@...om.net>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>,
	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irq: don't put module.h into irq.h for tracking irqgen modules.

On Tue, Oct 18, 2011 at 11:44 AM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:
> On 11-10-18 01:43 PM, Sebastian Andrzej Siewior wrote:
>> On Fri, Sep 30, 2011 at 09:53:57PM -0400, Paul Gortmaker wrote:
>>> irq/manage.c is now (as of b687380) using try_module_get and
>>> module_put and so it needs module.h (which it already has).
>>>
>>> Also convert the irq_alloc_descs variants to macros, since all
>>> they really do is is call the __irq_alloc_descs primitive.
>>> This avoids including export.h and no debug info is lost.
>>
>> macros, I see. THIS_MODULE is quite simple. What about moving this part from
>> module.h which is hidden behind ifdef MODULE and make it avaiable as a separate
>> headerfile with no children?
>
> Already done.  THIS_MODULE, because of its presence everywhere
> in non modular code is also in the export.h file.

As mentioned separately, this broke at least ARM in latest linux-next:
http://lkml.org/lkml/2011/10/25/396


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/