linux-kernel - Re: [PATCHv4 1/6] input/cma3000_d0x: Support devices without pdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACxGe6uAMugBRAqeN5D-HfX4G+DysLFjfp7=ZeC378cAdwOAwA@mail.gmail.com>
Date:	Tue, 25 Oct 2011 09:46:34 +0200
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc:	dmitry.torokhov@...il.com, sameo@...ux.intel.com,
	peter.ujfalusi@...com, jic23@....ac.uk, aghayal@...eaurora.org,
	david@...deman.nu, Shubhrajyoti@...com, saaguirre@...com,
	hemanthv@...com, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 1/6] input/cma3000_d0x: Support devices without pdata

On Tue, Oct 25, 2011 at 9:38 AM, Ricardo Ribalda Delgado
<ricardo.ribalda@...il.com> wrote:
> Hello Grant
>
>>> ---
>>
>> Drop this line, git cuts everything below a '---' line from the commit text.
>
> Done, thanks
>
>>
>> This binding needs documentation before it can be merged.
>
> Documentation/input/cma3000_d0x.txt is the right place ?

Documentation/devicetree/bindings/input

>> No of_device_id match table to match against compatible values?
>
> I think it is not needed, the device will be matched against the
> driver cma3000_d0x_spi.c and AFAIK on the spi/i2c devices you dont
> need the device_id match. But you know much more about this :).  Can
> you point me to a example where a spi driver uses of_device-id match.

Use an of_device_id table.  It's the right thing to do.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/