linux-kernel - Re: [PATCH RFC 2/8] blackfin: implement syscall restart generically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMjpGUeQch6_-wPRVrktLGFt5h3UV3usaD6XHu_gn82DFcEh1Q@mail.gmail.com>
Date:	Tue, 25 Oct 2011 20:01:38 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Jonas Bonn <jonas@...thpole.se>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH RFC 2/8] blackfin: implement syscall restart generically

On Sun, Oct 23, 2011 at 06:19, Jonas Bonn <jonas@...thpole.se> wrote:
> --- a/arch/blackfin/include/asm/syscall.h
> +++ b/arch/blackfin/include/asm/syscall.h
>
>  static inline long
>  syscall_get_nr(struct task_struct *task, struct pt_regs *regs)
>  {
> -       return regs->p0;
> +       return regs->orig_p0;
>  }

i'm not sure this is correct.  we set the orig_p0 to -1 when forcing
the syscall to go to restart.  shouldn't syscall_get_nr() still return
the right value ?

>  syscall_set_return_value(struct task_struct *task, struct pt_regs *regs,
>                          int error, long val)
>  {
> -       regs->r0 = error ? -error : val;
> +       regs->r0 = error ? error : val;
>  }

this fix is unrelated (and unmentioned in the changelog).  i also see
a bunch of other arches doing this.  so we should pull this change out
into a dedicated patchset, and fix all the arches at the same time.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/