lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 27 Oct 2011 00:55:55 +0530
From:	Raghavendra K T <raghukt@...ux.vnet.ibm.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	"H. Peter Anvin" <hpa@...or.com>, Gleb Natapov <gleb@...hat.com>,
	Virtualization <virtualization@...ts.linux-foundation.org>,
	"x86@...nel.org" <x86@...nel.org>, KVM <kvm@...r.kernel.org>,
	Dave Jiang <dave.jiang@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Stefano Stabellini <Stefano.Stabellini@...citrix.com>,
	Yinghai Lu <yinghai@...nel.org>,
	Sedat Dilek <sedat.dilek@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Xen <xen-devel@...ts.xensource.com>, Avi Kivity <avi@...hat.com>,
	Rik van Riel <riel@...hat.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Suzuki Poulose <suzuki@...ux.vnet.ibm.com>,
	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH RFC V2 5/5] kvm guest : pv-ticketlocks support for linux
 guests running on KVM hypervisor

On 10/26/2011 12:05 AM, Jeremy Fitzhardinge wrote:
> On 10/23/2011 12:07 PM, Raghavendra K T wrote:
>>
>> +#ifdef CONFIG_PARAVIRT_SPINLOCKS
>> +
>> +#ifdef CONFIG_KVM_DEBUG_FS
>> +
>> +#include<linux/debugfs.h>
>> +
>> +#endif /* CONFIG_KVM_DEBUG_FS */
>> +
>> +#endif /* CONFIG_PARAVIRT_SPINLOCKS */
>
> This is a big mess.  Is there any problem with including linux/debugfs.h
> unconditionally?  Or at least using "#if
> defined(CONFIG_PARAVIRT_SPINLOCKS)&&  defined(CONFIG_KVM_DEBUG_FS)"?
>

I agree. I 'll include unconditionally unless somebody objects.

>      J

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ