linux-kernel - Re: [PATCH 1/6] Staging: hv: mousevsc: Make boolean states boolean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111026235054.GA31883@suse.de>
Date:	Thu, 27 Oct 2011 01:50:54 +0200
From:	Greg KH <gregkh@...e.de>
To:	Joe Perches <joe@...ches.com>
Cc:	Haiyang Zhang <haiyangz@...rosoft.com>, dmitry.torokhov@...il.com,
	ohering@...e.com, linux-kernel@...r.kernel.org,
	virtualization@...ts.osdl.org, devel@...uxdriverproject.org
Subject: Re: [PATCH 1/6] Staging: hv: mousevsc: Make  boolean states  boolean

On Wed, Oct 26, 2011 at 03:46:51PM -0700, Joe Perches wrote:
> On Wed, 2011-10-26 at 08:07 +0200, Greg KH wrote:
> > On Tue, Oct 25, 2011 at 05:03:47PM -0700, Joe Perches wrote:
> > > On Tue, 2011-10-25 at 17:19 -0700, K. Y. Srinivasan wrote:
> > > > Make some state that is boolean in nature, a boolean variable.
> > > []
> > > > diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
> > > []
> > > @@ -148,7 +148,7 @@ struct  mousevsc_prt_msg {
> > > >   */
> > > >  struct mousevsc_dev {
> > > >  	struct hv_device	*device;
> > > > -	unsigned char		init_complete;
> > > > +	bool			init_complete;
> > > >  	struct mousevsc_prt_msg	protocol_req;
> > > >  	struct mousevsc_prt_msg	protocol_resp;
> > > >  	/* Synchronize the request/response if needed */
> > > > @@ -159,7 +159,7 @@ struct mousevsc_dev {
> > > >  	unsigned char		*report_desc;
> > > >  	u32			report_desc_size;
> > > >  	struct hv_input_dev_info hid_dev_info;
> > > > -	int			connected;
> > > > +	bool			connected;
> > > >  	struct hid_device       *hid_device;
> > > >  };
> > > 
> > > One of the bools should be moved to be adjacent to the other.
> > For a mouse driver, it really doesn't matter.
> 
> 'course it doesn't matter, just like whitespace
> doesn't matter.  It's just done for form's sake.

Not at all.

Whitespace does matter, there is documented proof of that.

The fact that you want to move a bool to a different part of a structure
really is only your personal choice.  It doesn't matter for size or
layout to make this code work better at all to do this.

This is your personal opinion only, please don't construe it as anything
else.

greg k-h

> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/