lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Oct 2011 23:21:13 -0700 From: Stephen Warren <swarren@...dia.com> To: Chanho Park <chanho61.park@...sung.com>, "linus.walleij@...aro.org" <linus.walleij@...aro.org>, "Baohua.Song@....com" <Baohua.Song@....com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> CC: Kyungmin Park <kyungmin.park@...sung.com> Subject: RE: [PATCH] drivers: pinctrl: add a pin_base for sparse gpio-ranges Chanho Park wrote at Tuesday, October 25, 2011 10:22 PM: > This patch enables mapping a base offset of gpio ranges with > a pin offset even if does'nt matched. A base of pinctrl_gpio_range > means a base offset of gpio. However, we cannot convert gpio to pin > number for sparse gpio ranges just only using a gpio base offset. > We can convert a gpio to real pin number(even if not matched) using > a new pin_base which means a base pin offset of requested gpio range. ... > diff --git a/Documentation/pinctrl.txt b/Documentation/pinctrl.txt ... > @@ -289,38 +291,12 @@ So this complex system has one pin controller handling two different > GPIO chips. Chip a has 16 pins and chip b has 8 pins. They are mapped in > the global GPIO pin space at: > > -chip a: [32 .. 47] > -chip b: [48 .. 55] > - > -When GPIO-specific functions in the pin control subsystem are called, these > -ranges will be used to look up the apropriate pin controller by inspecting > -and matching the pin to the pin ranges across all controllers. When a > -... [ quit a few lines of documentation removed] > -(If the GPIO subsystem is ever refactored to use a local per-GPIO controller > -pin space, this mapping will need to be augmented accordingly.) > - > +chip a: > + gpio-range : [32 .. 47] > + pin-range : [32 .. 47] > +chip b: > + gpio-range : [48 .. 55] > + pin-range : [64 .. 71] I'm all for replacing the example here with something more complete, but removing all that text from the documentation doesn't seem right. ... > diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h > index 90dd28b..7768e44 100644 > --- a/include/linux/pinctrl/pinctrl.h > +++ b/include/linux/pinctrl/pinctrl.h > @@ -127,6 +127,7 @@ struct pinctrl_pin_desc { > * @name: a name for the chip in this range > * @id: an ID number for the chip in this range > * @base: base offset of the GPIO range > + * @pin_base: base pin offset of the GPIO range This may be bike-shedding, but I'd tend to call this "gpio_base", since it's the first "gpio" number of this range, not the first "pin" number ("pins" are used in the pinctrl subsystem, but "gpios" by the GPIO Subsystem) -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists