linux-kernel - Re: [PATCH UPDATED 10/13] block, cfq: unlink cfq_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111027161701.GB29899@google.com>
Date:	Thu, 27 Oct 2011 09:17:01 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	axboe@...nel.dk, ctalbott@...gle.com, rni@...gle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH UPDATED 10/13] block, cfq: unlink cfq_io_context's
 immediately

Hello,

On Thu, Oct 27, 2011 at 10:31:19AM -0400, Vivek Goyal wrote:
> On Wed, Oct 26, 2011 at 02:31:07PM -0700, Tejun Heo wrote:
> >  	BUG_ON(atomic_long_read(&ioc->refcount) <= 0);
> > +	if (locked_q)
> > +		lockdep_assert_held(locked_q->queue_lock);
> >  
> 
> Looks like lockdep_assert_held() can't be used if !CONFIG_LOCKDEP. So
> Jens had put following patch to fix one compilation issue. You might
> want to provide a null definition of lockdep_assert_held() in case
> of !CONFIG_LOCKDEP.
> 
> commit 334c2b0b8b2ab186fa198413386cba41fffcb4f2
> Author: Jens Axboe <axboe@...nel.dk>
> Date:   Tue Oct 25 15:51:48 2011 +0200
> 
>     blk-throttle: use queue_is_locked() instead of lockdep_is_held()
>     
>     We can't use the latter if !CONFIG_LOCKDEP.
>     
>     Reported-by: Sedat Dilek <sedat.dilek@...glemail.com>
>     Signed-off-by: Jens Axboe <axboe@...nel.dk>

Eh?  lockdep.h has dummy definition if !CONFIG_LOCKDEP.  If
lockdep_is_held() is causing compilation failure on !CONFIG_LOCKDEP,
it's more likely to be have been caused by missing include than
anything else.  Jens, what was the failure?  lockdep_is_held()
provides way better protection against locking mistakes than
spin_is_locked().

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/