linux-kernel - Re: [PATCH 1/2] pinmux: Remove double pin validity check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAfyv35wup69rvZ0yQpzYfqeE8r+1Rcimr53rFoaBF09X=tTTw@mail.gmail.com>
Date:	Thu, 27 Oct 2011 20:39:31 +0200
From:	Belisko Marek <marek.belisko@...il.com>
To:	Stephen Warren <swarren@...dia.com>
Cc:	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] pinmux: Remove double pin validity check.

On Thu, Oct 27, 2011 at 6:37 PM, Stephen Warren <swarren@...dia.com> wrote:
> Belisko Marek wrote at Wednesday, October 26, 2011 2:57 PM:
>> Function pin_is_valid just call pin_desc_get which is in pin_request
>> call some line below. Remove pin_is_valid() check.
> ...
>> @@ -112,16 +112,6 @@ static int pin_request(struct pinctrl_dev *pctldev,
>>
>>       dev_dbg(&pctldev->dev, "request pin %d for %s\n", pin, function);
>>
>> -     if (!pin_is_valid(pctldev, pin)) {
>> -             dev_err(&pctldev->dev, "pin is invalid\n");
>> -             return -EINVAL;
>> -     }
>
> So that makes sense.
>
>> -
>> -     if (!function) {
>> -             dev_err(&pctldev->dev, "no function name given\n");
>> -             return -EINVAL;
>> -     }
>
> But I don't think you want to remove that? Oh actually, perhaps removing
> that /is/ valid, since it's an internal function and can't be called with
> a NULL function parameter. But, you should mention why in the changelog
> so it doesn't look like a mistake.
Well it's not removed. It's moved below pin_desc_get call.
>
> --
> nvpublic
>
>

regards,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/