linux-kernel - Re: [PATCH] config: Add 'make kvmconfig'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111027193448.GA3514@merkur.ravnborg.org>
Date:	Thu, 27 Oct 2011 21:34:48 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Sasha Levin <levinsasha928@...il.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Michal Marek <mmarek@...e.cz>,
	Pekka Enberg <penberg@...helsinki.fi>,
	linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] config: Add 'make kvmconfig'

On Thu, Oct 27, 2011 at 02:07:14PM +0200, Sasha Levin wrote:
> This patch adds 'make kvmconfig' which allows to add KVM guest support
> to a config file.
> 
> This allows for easier testing of configurations under virtualized
> environments.
> 
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Michal Marek <mmarek@...e.cz>
> Cc: Pekka Enberg <penberg@...helsinki.fi>
> Cc: linux-kbuild@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Suggested-by: Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Sasha Levin <levinsasha928@...il.com>

Two points about the implmentation that I do not like...

The kvmconfig is an x86 specific thing - so it does not belong
in the scripts/kconfig/Makefile

The *config namespace is general config targets.

Suggestion:
Move the implmentation to arch/x86/Makefile and name the target
something that does not match the *config pattern.

Suggestion:

   make kvmbootable

To tell that this convert the current config to a kvmbootable config.

And then add the target to the x86 specific help too.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/