linux-kernel - Re: [PATCH] staging: bcm: Fixed major coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Oct 2011 07:52:23 +0200
From:	Greg KH <greg@...ah.com>
To:	Matthew Piehl <matthew.piehl232@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org, asedeno@....edu,
	lucas.demarchi@...fusion.mobi, Linux-kernel@...r.kernel.org,
	shemminger@...tta.com
Subject: Re: [PATCH] staging: bcm: Fixed major coding style issues

On Wed, Oct 26, 2011 at 05:52:40PM -0500, Matthew Piehl wrote:
> Fixed major coding style issues and removed all checkpatch errors and
> and many warnings.

You just did a whole lot of things all in one patch, making it very hard
to review.

Please break it up into one-patch-per-logical-change, and no, "fix
everything" is not a single logical change :)

Also, please check Linus's current tree to see if this even applies, I
don't want you to do work that's already been done as that would be sad.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/