linux-kernel - Re: [PATCH 2/2] pinmux: Unify pin type from signed to unsigned.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAfyv35KsspWGAkmZmZOaDw5v3tngKuV8YqQ_fvZU4azHCUtYA@mail.gmail.com>
Date:	Thu, 27 Oct 2011 08:13:04 +0200
From:	Belisko Marek <marek.belisko@...il.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	swarren@...dia.com, linus.walleij@...aro.org,
	grant.likely@...retlab.ca, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] pinmux: Unify pin type from signed to unsigned.

On Wed, Oct 26, 2011 at 11:06 PM, David Rientjes <rientjes@...gle.com> wrote:
> On Wed, 26 Oct 2011, Marek Belisko wrote:
>
>> diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h
>> index 3605e94..34c33c7 100644
>> --- a/include/linux/pinctrl/pinctrl.h
>> +++ b/include/linux/pinctrl/pinctrl.h
>> @@ -112,7 +112,7 @@ struct pinctrl_desc {
>>  extern struct pinctrl_dev *pinctrl_register(struct pinctrl_desc *pctldesc,
>>                               struct device *dev, void *driver_data);
>>  extern void pinctrl_unregister(struct pinctrl_dev *pctldev);
>> -extern bool pin_is_valid(struct pinctrl_dev *pctldev, int pin);
>> +extern bool pin_is_valid(struct pinctrl_dev *pctldev, unsigned int pin);
>>  extern void pinctrl_add_gpio_range(struct pinctrl_dev *pctldev,
>>                               struct pinctrl_gpio_range *range);
>>  extern void pinctrl_remove_gpio_range(struct pinctrl_dev *pctldev,
>> @@ -123,7 +123,7 @@ extern void *pinctrl_dev_get_drvdata(struct pinctrl_dev *pctldev);
>>
>>
>>  /* Sufficiently stupid default function when pinctrl is not in use */
>> -static inline bool pin_is_valid(struct pinctrl_dev *pctldev, int pin)
>> +static inline bool pin_is_valid(struct pinctrl_dev *pctldev, unsigned int pin)
>>  {
>>       return pin >= 0;
>>  }
>
>
> So this would just become return true, right?
Right I've overlooked it. Will send update version.
>

thanks,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/