linux-kernel - Re: kdump: No udev events for memory hotplug?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111027073058.GA2422@osiris.boeblingen.de.ibm.com>
Date:	Thu, 27 Oct 2011 09:30:58 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	Michael Holzheu <holzheu@...ux.vnet.ibm.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	schwidefsky@...ibm.com, kexec@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Kay Sievers <kay.sievers@...y.org>,
	Dave Hansen <haveblue@...ibm.com>
Subject: Re: kdump: No udev events for memory hotplug?

On Wed, Oct 26, 2011 at 03:24:49PM -0400, Vivek Goyal wrote:
> On Wed, Oct 26, 2011 at 06:08:12PM +0200, Michael Holzheu wrote:
> > Hello Vivek and Eric,
> > 
> > I noticed that on my system kernel 3.1 *no* udev events for memory
> > hotplug are generated. Same on my RHEL6.1.
> > 
> > # udevadm monitor
> > # echo offline > /sys/devices/system/memory/memory4/state
> > 
> > -> No event
> > 
> > But we need the udev events in order to do a kdump reload for setting up
> > the ELF loads correctly.
> > 
> > In my /etc/udev/rules.d/98-kexec.rules there are rules for memory
> > hotplug:
> > 
> > SUBSYSTEM=="memory", ACTION=="add", PROGRAM="/etc/init.d/kdump restart"
> > SUBSYSTEM=="memory", ACTION=="remove", PROGRAM="/etc/init.d/kdump
> > restart"
> > 
> > Perhaps/probably I am missing something?
> 
> I don't know. Sounds like a bug. I have never looked into it. CCing Kay,
> if he has any thoughts.
> 
> Are any events generated for memory add?

Looks like uevents are only genereted when memory gets registered and
unregistered, but not when when it gets set online or offline.
To achieve that you would need to add similar code to
store_mem_state()/memory_block_change_state() in drivers/base/memory.c
like we have it already in store_online() in drivers/base/cpu.c
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/