linux-kernel - Re: [PATCH v3 1/4] regulator: helper routine to extract regulator_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111027080953.GB18360@opensource.wolfsonmicro.com>
Date:	Thu, 27 Oct 2011 10:09:53 +0200
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Rajendra Nayak <rnayak@...com>
Cc:	grant.likely@...retlab.ca, devicetree-discuss@...ts.ozlabs.org,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	tony@...mide.com, lrg@...com, b-cousson@...com, patches@...aro.org,
	linux-kernel@...r.kernel.org, shawn.guo@...escale.com
Subject: Re: [PATCH v3 1/4] regulator: helper routine to extract
 regulator_init_data

On Thu, Oct 27, 2011 at 01:26:22PM +0530, Rajendra Nayak wrote:

> +	min_uV = of_get_property(np, "regulator-min-uV", NULL);
> +	if (min_uV)
> +		(*init_data)->constraints.min_uV = be32_to_cpu(*min_uV);
> +	max_uV = of_get_property(np, "regulator-max-uV", NULL);
> +	if (max_uV)
> +		(*init_data)->constraints.max_uV = be32_to_cpu(*max_uV);

If we have min_uV and max_uV we should also set REGULATOR_CHANGE_VOLTAGE
(and similarly for the currents).  

We should also have a way to enable status changes - since there's an
always_on property (which does make sense) I'd suggest that as a first
pass we should enable status changes if always_on is not set (these two
things are a bit redundant in the existing constrints).  This is
slightly risky as you can get a situation where new device driver
support for regulators starts unexpectedly turning off supplies but
that's always going to be a risk with constraints disassociated from the
kernel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/