linux-kernel - Re: [PATCH] config: Add 'make kvmconfig'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1319793409.3235.16.camel@lappy>
Date:	Fri, 28 Oct 2011 11:16:49 +0200
From:	Sasha Levin <levinsasha928@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Sam Ravnborg <sam@...nborg.org>,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Michal Marek <mmarek@...e.cz>,
	Pekka Enberg <penberg@...helsinki.fi>,
	linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] config: Add 'make kvmconfig'

On Fri, 2011-10-28 at 09:52 +0200, Geert Uytterhoeven wrote:
> On Fri, Oct 28, 2011 at 09:03, Ingo Molnar <mingo@...e.hu> wrote:
> > * Sam Ravnborg <sam@...nborg.org> wrote:
> >> The kvmconfig is an x86 specific thing - so it does not belong
> >> in the scripts/kconfig/Makefile
> >>
> >> The *config namespace is general config targets.
> >>
> >> Suggestion:
> >> Move the implmentation to arch/x86/Makefile and name the target
> >> something that does not match the *config pattern.
> >>
> >> Suggestion:
> >>
> >>    make kvmbootable
> >>
> >> To tell that this convert the current config to a kvmbootable config.
> >>
> >> And then add the target to the x86 specific help too.
> >
> > KVM itself is not x86 specific (although this patch obviously is), so
> > we'd like to keep at least the naming non-x86.
> >
> > Furthermore, the functionality generally fits into the pattern that
> > 'oldconfig' does: it changes an existing config - so having 'config'
> > in the name somewhere makes quite a bit of sense. If i didn't know
> > what 'kvmbootable' does i couldnt guess that it touches the .config -
> > while the *config pattern makes that patently obvious.
> >
> > Could we set aside some sort of name for such subsystem specific
> > purposes and be done with it? Could we reuse the 'defconfig'
> > naming perhaps and make it richer:
> >
> >        make defconfig kvm
> >
> > or:
> >
> >        make defconfig-kvm
> >
> > ? It would be very obvious at a glance what it does.
> 
> This fits in the generic "I have a .config and I want to enable an additional
> option" functionality:
> 
> make oldconfig CONFIG_KVMTOOL_TEST_ENABLE=y
> 
> Don't we already have that support? I seem to remember it flying by.
> Or was it just a proposal that never got implemented?

AFAIK it never got merged.

-- 

Sasha.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/