linux-kernel - Re: [PATCH] asm-generic/gpio.h: merge basic gpiolib wrappers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111028124200.GU19187@n2100.arm.linux.org.uk>
Date:	Fri, 28 Oct 2011 13:42:00 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Mike Frysinger <vapier@...too.org>,
	Linus Walleij <linus.walleij@...aro.org>
Cc:	Sekhar Nori <nsekhar@...com>, Kevin Hilman <khilman@...com>,
	Grant Likely <grant.likely@...retlab.ca>,
	linux-arch@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	davinci-linux-open-source@...ux.davincidsp.com
Subject: Re: [PATCH] asm-generic/gpio.h: merge basic gpiolib wrappers

On Fri, Oct 28, 2011 at 02:15:00PM +0200, Mike Frysinger wrote:
> On Thu, Oct 27, 2011 at 15:11, Russell King - ARM Linux wrote:
> > This is extremely dangerous.  Consider for example this code
> > (see ARM mach-davinci's gpio.h):
> 
> it's interesting you highlight davinci.  if i'm reading things
> correctly, the current davinci code is broken today and my v2 proposed
> patch actually fixes it.

That looks like an error in patch 5f3fcf9649dbb010ccac41259d04147775ec8fc2
(ARM: 7040/1: mach-davinci: break out GPIO driver specifics) which does
this:

-#define __ARM_GPIOLIB_COMPLEX

Linus, can you send a fix?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/