linux-kernel - Re: [PATCH] tty/serial: atmel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111028131811.GA25743@suse.de>
Date:	Fri, 28 Oct 2011 15:18:11 +0200
From:	Greg KH <gregkh@...e.de>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	Sven Schnelle <svens@...ckframe.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	devicetree-discuss@...ts.ozlabs.org,
	Rob Herring <robherring2@...il.com>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty/serial: atmel_serial: fix compilation

On Fri, Oct 28, 2011 at 02:38:09PM +0200, Nicolas Ferre wrote:
> On 10/28/2011 01:33 PM, Sven Schnelle :
> > If CONFIG_OF is disabled, compilation fails with:
> > 
> > drivers/tty/serial/atmel_serial.c: In function 'atmel_serial_probe':
> > drivers/tty/serial/atmel_serial.c:1788: error: implicit declaration of function 'of_alias_get_id'
> > 
> > Fix this by adding the proper CONFIG_OF checks.
> 
> Yes, but I would like to avoid this and I have made a patch to address
> this issue. I have sent it to the device tree guys yesterday:
> "[PATCH] dt: add empty of_alias_get_id() for non-dt builds"
> 
> Maybe we can wait a little and see if it reaches Linus' tree on time. If
> it is not, I will make sure that such a fix make it to mainline.

I agree, the other dt: patch is the correct way to fix this, not this
driver-only #ifdef hack.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/