linux-kernel - Re: [patch] drm/i915: fix if statement (bogus semi-colon)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <f80fcd$2bbqtl@fmsmga001.fm.intel.com>
Date:	Fri, 28 Oct 2011 18:20:20 +0100
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	Keith Packard <keithp@...thp.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	David Airlie <airlied@...ux.ie>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] drm/i915: fix if statement (bogus semi-colon)

On Fri, 28 Oct 2011 10:10:26 -0700, Keith Packard <keithp@...thp.com> wrote:
> On Fri, 28 Oct 2011 14:42:41 +0300, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> 
> > -	if (needs_idle_maps());
> > +	if (needs_idle_maps())
> 
> how embarrassing is that?

Actually it served an ulterior purpose and by exercising the workaround
showed us that it contained a more subtle bug. I believe therefore Ben
did it deliberately ;-)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/