linux-kernel - Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111028192710.361093ea@pyx>
Date:	Fri, 28 Oct 2011 19:27:10 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Paul Schilling <paul.s.schilling@...il.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>,
	"David S. Miller" <davem@...emloft.net>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC
 bug.

On Thu, 27 Oct 2011 13:55:21 -0500
Paul Schilling <paul.s.schilling@...il.com> wrote:

> The Vortex86dx uses RDC IDE peripheral integrated into the SOC.  The
> CRC design is
> broken in the Vortex86dx and sx.  The original reference can be found
> in the Linux kernel itself.
> 
> The Vortex86sx uses the RDC D1010.
> The Vortex86dx uses the RDC D1011.
> Both of which have broken CRC hardware which breaks DMA.

CRC hardware is only used for *UDMA* yet your change also disabled MWDMA.


> >>       static const struct ata_port_info info_rdc_11 = {
> >>               .flags = ATA_FLAG_SLAVE_POSS,
> >>               .pio_mask = ATA_PIO4,
> >> -             .mwdma_mask = ATA_MWDMA2,
> >> +             .mwdma_mask = 0,
> >> +             .udma_mask = 0,

Why ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/