lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <201110300035.27985.marek.vasut@gmail.com>
Date:	Sun, 30 Oct 2011 00:35:27 +0200
From:	Marek Vasut <marek.vasut@...il.com>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Paul Bolle <pebolle@...cali.nl>, linux-kernel@...r.kernel.org,
	Eric Miao <eric.y.miao@...il.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] [TRIVIAL] ARM: pxa: Fix typo 'CONFIG_BACKLIGHT_PWM__MODULE'

> On Tue, 11 Oct 2011, Paul Bolle wrote:
> > Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> > ---
> > Untested (I don't think I've got the hardware, nor have I got the
> > toolchain at hand, etc.).
> > 
> >  arch/arm/mach-pxa/colibri-pxa270-income.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/mach-pxa/colibri-pxa270-income.c
> > b/arch/arm/mach-pxa/colibri-pxa270-income.c index 80538b8..248804b
> > 100644
> > --- a/arch/arm/mach-pxa/colibri-pxa270-income.c
> > +++ b/arch/arm/mach-pxa/colibri-pxa270-income.c
> > @@ -183,7 +183,7 @@ static inline void income_lcd_init(void) {}
> > 
> >  /***********************************************************************
> >  *******
> >  
> >   * Backlight
> >   ***********************************************************************
> >   *******/
> > 
> > -#if defined(CONFIG_BACKLIGHT_PWM) ||
> > defined(CONFIG_BACKLIGHT_PWM__MODULE) +#if defined(CONFIG_BACKLIGHT_PWM)
> > || defined(CONFIG_BACKLIGHT_PWM_MODULE)
> > 
> >  static struct platform_pwm_backlight_data income_backlight_data = {
> >  
> >  	.pwm_id		= 0,
> >  	.max_brightness	= 0x3ff,
> 
> I'd like to have this at least compile-tested, adding some CCs.

The change is visually ok, add my:

Acked-by: Marek Vasut <marek.vasut@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ