linux-kernel - Re: [PATCH 1/2] gpio: pca953x: remove unneeded check for chip type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 29 Oct 2011 08:58:20 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	linux-kernel@...r.kernel.org
Cc:	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH 1/2] gpio: pca953x: remove unneeded check for chip type

On Fri, Oct 14, 2011 at 03:31:59PM +0200, Wolfram Sang wrote:
> We can assume our own device_id table is correct, so remove checking if
> the chip type is valid. (The check was bogus anyway: If it found an
> invalid entry, it returned with 0!) This is in preparation for further
> cleanups.
> 
> Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
> Cc: Grant Likely <grant.likely@...retlab.ca>

Ping for this mini-series.

> ---
>  drivers/gpio/gpio-pca953x.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index c43b8ff..45de6a4 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -673,10 +673,8 @@ static int __devinit pca953x_probe(struct i2c_client *client,
>  
>  	if (chip->chip_type == PCA953X_TYPE)
>  		device_pca953x_init(chip, invert);
> -	else if (chip->chip_type == PCA957X_TYPE)
> -		device_pca957x_init(chip, invert);
>  	else
> -		goto out_failed;
> +		device_pca957x_init(chip, invert);
>  
>  	ret = pca953x_irq_setup(chip, id, irq_base);
>  	if (ret)
> -- 
> 1.7.6.3
> 

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)