linux-kernel - Re: + oom-thaw-threads-if-oom-killed-thread-is-frozen-before-deferring.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20111029085638.GA6368@tiehlicka.suse.cz>
Date:	Sat, 29 Oct 2011 10:56:38 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	akpm@...gle.com
Cc:	mm-commits@...r.kernel.org, rientjes@...gle.com,
	kamezawa.hiroyu@...fujitsu.com, kosaki.motohiro@...fujitsu.com,
	oleg@...hat.com, rjw@...k.pl, linux-mm@...ck.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: +
 oom-thaw-threads-if-oom-killed-thread-is-frozen-before-deferring.patch added
 to -mm tree

Sorry for the really late reply.

On Mon 10-10-11 15:46:25, akpm@...gle.com wrote:
> From: David Rientjes <rientjes@...gle.com>
> Subject: oom: thaw threads if oom killed thread is frozen before deferring
> 
> If a thread has been oom killed and is frozen, thaw it before returning to
> the page allocator.  Otherwise, it can stay frozen indefinitely and no
> memory will be freed.
> 
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> Reported-by: Michal Hocko <mhocko@...e.cz>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> Cc: "Rafael J. Wysocki" <rjw@...k.pl>
> Cc: Michal Hocko <mhocko@...e.cz>
> Signed-off-by: Andrew Morton <akpm@...gle.com>

Can we still update the tags?
The issue has been reported by Konstantin Khlebnikov <khlebnikov@...nvz.org>
and I think that we want SOB from Rafael here (he originally SOB the
previous patch which thawed tasks from oom_kill_task). You can also add
my Acked-by.

> ---
> 
>  mm/oom_kill.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff -puN mm/oom_kill.c~oom-thaw-threads-if-oom-killed-thread-is-frozen-before-deferring mm/oom_kill.c
> --- a/mm/oom_kill.c~oom-thaw-threads-if-oom-killed-thread-is-frozen-before-deferring
> +++ a/mm/oom_kill.c
> @@ -32,6 +32,7 @@
>  #include <linux/mempolicy.h>
>  #include <linux/security.h>
>  #include <linux/ptrace.h>
> +#include <linux/freezer.h>
>  
>  int sysctl_panic_on_oom;
>  int sysctl_oom_kill_allocating_task;
> @@ -320,8 +321,11 @@ static struct task_struct *select_bad_pr
>  		 * blocked waiting for another task which itself is waiting
>  		 * for memory. Is there a better alternative?
>  		 */
> -		if (test_tsk_thread_flag(p, TIF_MEMDIE))
> +		if (test_tsk_thread_flag(p, TIF_MEMDIE)) {
> +			if (unlikely(frozen(p)))
> +				thaw_process(p);
>  			return ERR_PTR(-1UL);
> +		}
>  		if (!p->mm)
>  			continue;
>  
> _
> Subject: Subject: oom: thaw threads if oom killed thread is frozen before deferring
> 
> Patches currently in -mm which might be from rientjes@...gle.com are
> 
> origin.patch
> linux-next.patch
> oom-avoid-killing-kthreads-if-they-assume-the-oom-killed-threads-mm.patch
> oom-remove-oom_disable_count.patch
> oom-fix-race-while-temporarily-setting-currents-oom_score_adj.patch
> mm-avoid-null-pointer-access-in-vm_struct-via-proc-vmallocinfo.patch
> mm-compaction-make-compact_zone_order-static.patch
> oom-thaw-threads-if-oom-killed-thread-is-frozen-before-deferring.patch
> cpusets-avoid-looping-when-storing-to-mems_allowed-if-one-node-remains-set.patch
> 

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/