linux-kernel - [PATCH 1/2] staging: line6: accept all MIDI channels by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1319985641-25648-2-git-send-email-stefanha@gmail.com>
Date:	Sun, 30 Oct 2011 14:40:40 +0000
From:	Stefan Hajnoczi <stefanha@...il.com>
To:	<grabner@....tugraz.at>
Cc:	<devel@...uxdriverproject.org>, <linux-kernel@...r.kernel.org>,
	Stefan Hajnoczi <stefanha@...il.com>
Subject: [PATCH 1/2] staging: line6: accept all MIDI channels by default

MIDI messages can be filtered by channel so that multiple devices can
coexist on the same MIDI bus.  By default all channels should be
accepted; this is important because Line6 devices seem to have different
default channels.

Accept all MIDI messages by default to avoid confusing users when
messages are silently filtered out.  If filtering is necessary due to
multiple devices on the bus, users can set the midi_mask_transmit and
midi_mask_receive sysfs attributes.

Signed-off-by: Stefan Hajnoczi <stefanha@...il.com>
---
 drivers/staging/line6/midi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/line6/midi.c b/drivers/staging/line6/midi.c
index e554a2d..2d81d2a 100644
--- a/drivers/staging/line6/midi.c
+++ b/drivers/staging/line6/midi.c
@@ -399,8 +399,8 @@ int line6_init_midi(struct usb_line6 *line6)
 		return err;
 
 	line6midi->line6 = line6;
-	line6midi->midi_mask_transmit = 1;
-	line6midi->midi_mask_receive = 4;
+	line6midi->midi_mask_transmit = 0xffff;
+	line6midi->midi_mask_receive = 0xffff;
 	line6->line6midi = line6midi;
 
 	err = snd_device_new(line6->card, SNDRV_DEV_RAWMIDI, line6midi,
-- 
1.7.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/