[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOJsxLHWtN+88CErqbDDqT20saDyxLcdca8R2eV9nA9jvjUdGw@mail.gmail.com>
Date: Tue, 1 Nov 2011 08:32:54 +0200
From: Pekka Enberg <penberg@...nel.org>
To: David Rientjes <rientjes@...gle.com>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
Tejun Heo <tj@...nel.org>, Yinghai Lu <yinghai@...nel.org>,
"H. Peter Anvin" <hpa@...ux.intel.com>
Subject: Re: [RFC/PATCH 6/7] x86, mm: Prepare zone_sizes_init() for unification
Hi David,
On Tue, Nov 1, 2011 at 12:56 AM, David Rientjes <rientjes@...gle.com> wrote:
> I'd just fold patch 7 into this, it doesn't make much sense to have add
> CONFIG_HIGHMEM code for 64-bit, for example, just to make the next patch
> simpler.
Actually, I don't agree.
Whenever I've done unification patches, I've always made sure the
patch that does the actual unification is just code shuffling. That
improves bisectability and makes reviewing easier.
Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists