linux-kernel - Re: [PATCH] Stageing: bcm: fixed spacing coding style in led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1320145665.14409.149.camel@x61.thuisdomein>
Date:	Tue, 01 Nov 2011 12:07:45 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Ciaran McCormick <ciaranmccormick@...il.com>
Cc:	gregkh@...e.de, shemminger@...tta.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Stageing: bcm: fixed spacing coding style in
 led_control.c

Stageing? And you might as well drop the filename from the summary. By
the way, are the other files (if any) of this driver any better (I
haven't checked)?

On Tue, 2011-11-01 at 10:44 +0000, Ciaran McCormick wrote:
> ---
>  drivers/staging/bcm/led_control.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c
> index 16e939f..28c3382 100644
> --- a/drivers/staging/bcm/led_control.c
> +++ b/drivers/staging/bcm/led_control.c
> @@ -5,8 +5,8 @@
>  
>  static B_UINT16 CFG_CalculateChecksum(B_UINT8 *pu8Buffer, B_UINT32 u32Size)
>  {
> -	B_UINT16 	u16CheckSum=0;
> -	while(u32Size--) {
> +	B_UINT16	u16CheckSum = 0;
> +	while (u32Size--) {
>  		u16CheckSum += (B_UINT8)~(*pu8Buffer);

I'd say this line might need a space after the cast.

>  	    pu8Buffer++;
>  	}
> @@ -16,7 +16,7 @@ BOOLEAN IsReqGpioIsLedInNVM(PMINI_ADAPTER Adapter, UINT gpios)
>  {
>  	INT Status ;
>  	Status = (Adapter->gpioBitMap & gpios) ^ gpios ;

You missed the space before the semicolons here.

> -	if(Status)
> +	if (Status)
>  		return FALSE;
>  	else
>  		return TRUE;

But, more importantly, why only do whitespace related stuff? Almost
every second word apparently needs to be restyled here. Is doing just
whitespace related stuff worthwhile? (This is not a rhetorical question.
I'm actually wondering what Greg prefers).


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/