linux-kernel - Re: [PATCH] TTY: tty flip buffer change reserve memory strategy.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111101114138.1debca90@bob.linux.org.uk>
Date:	Tue, 1 Nov 2011 11:41:38 +0000
From:	Alan Cox <alan@...ux.intel.com>
To:	Ilya Zykov <ilya@...x.ru>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] TTY: tty flip buffer change reserve memory strategy.

> Pty use chunk more 256 bytes very often. More program for communicate
> with pppd use pty master - slave. If often kmalloc()-kfree() calls
> don't provoke memory fragmentation and flush TLB, I agree it isn't
> important.

I think any work of this nature ought to involve benchmarking. That
would answer the questions better. kmalloc/kfree is a smart allocator
so shouldn't cause problems, and it doesn't manipulate address space so
shouldn't cause TLB misses.

You want to make these changes, you say they are needed, but what
actually talks is real numbers.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/