linux-kernel - Re: [PATCH] x86: call stop_machine_text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EAFE05B.6020607@hitachi.com>
Date:	Tue, 01 Nov 2011 21:04:43 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Rabin Vincent <rabin@....in>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Jason Baron <jbaron@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] x86: call stop_machine_text_poke() on all CPUs

(2011/10/28 21:30), Rabin Vincent wrote:
> On Fri, Oct 28, 2011 at 11:28:39AM +0900, Masami Hiramatsu wrote:
>> (2011/10/27 16:54), Rabin Vincent wrote:
>>> It appears that stop_machine_text_poke() wants to be called on all CPUs,
>>> like it's done from text_poke_smp().  Fix text_poke_smp_batch() to do
>>> this.
>>
>> cpu_mask==NULL finally falls back to cpu_online_mask, but even though
>> it should be specified correctly.
> 
> Not quite.  Passing NULL to __stop_machine means that the function will
> be called on any one CPU only, while passing cpu_online_mask means that
> the function will be called on all CPUs.  So this patch is a behaviour
> change/bug fix, not just a clarification.

Aah, Right! I just misunderstood.
Then this must be a bugfix!

Thanks!

-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/