linux-kernel - Re: [PATCH 2/2] pch_uart: Delete modem status interrupt enable code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111101125757.4ef7f883@bob.linux.org.uk>
Date:	Tue, 1 Nov 2011 12:57:57 +0000
From:	Alan Cox <alan@...ux.intel.com>
To:	Tomoya MORINAGA <tomoya-linux@....lapis-semi.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com, kok.howg.ewe@...el.com
Subject: Re: [PATCH 2/2] pch_uart: Delete modem status interrupt enable code

> (pch_uart device has auto hardware flow control function. So,
> pch_uart driver doesn't have to control modem status interrupt.)

This is true for flow control bits but not for incoming carrier detect ?

> This patch deletes the code.

> +	dev_info(priv->port.dev,
> +		"PCH UART : Modem status interrupt is not
> supported.\n"); }

dev_info seems wrong here. Does the user need to know this ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/