linux-kernel - Re: [PATCH] drm/i915: Fix object refcount leak on mmappable size limit error path.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pqhb232g.fsf@eliezer.anholt.net>
Date:	Tue, 01 Nov 2011 09:57:27 -0700
From:	Eric Anholt <eric@...olt.net>
To:	Keith Packard <keithp@...thp.com>, linux-kernel@...r.kernel.org
Cc:	stable@...nel.org
Subject: Re: [PATCH] drm/i915: Fix object refcount leak on mmappable size limit error path.

On Mon, 31 Oct 2011 23:58:25 -0700, Keith Packard <keithp@...thp.com> wrote:
Non-text part: multipart/signed
> On Mon, 31 Oct 2011 23:16:21 -0700, Eric Anholt <eric@...olt.net> wrote:
> 
> > I've been seeing memory leaks on my system in the form of large
> > (300-400MB) GEM objects created by now-dead processes laying around
> > clogging up memory.  I usually notice when it gets to about 1.2GB of
> > them.  Hopefully this clears up the issue, but I just found this bug
> > by inspection.
> > 
> > Signed-off-by: Eric Anholt <eric@...olt.net>
> > Cc: stable@...nel.org
> 
> Reviewed-by: Keith Packard <keithp@...thp.com
> 
> I wouldn't mind having someone audit the driver for more places where
> drm_gem_object_lookup might not be paired with drm_gem_object_unreference...

I went ahead and finished the read-through, and everything else looks
good.

Content of type "application/pgp-signature" skipped