linux-kernel - Re: [PATCH] asoc: tegra: wm8903: Simplify pin disconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 1 Nov 2011 18:09:57 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Taylor Hutt <thutt@...omium.org>
Cc:	swarren@...dia.com, Liam Girdwood <lrg@...mlogic.co.uk>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] asoc: tegra: wm8903: Simplify pin disconnect

On Tue, Nov 01, 2011 at 09:26:11AM -0700, Taylor Hutt wrote:

> (Note that this patch fails the kernel patch checker because
>  the 'M' macro produces an error that it's value should be enclosed
>  in parenthesis; this is not actually possible for this use & expansion.)

So, this whole patch doesn't look like a Linux patch in either the code
itself or the way it's presented.  I remember having similar problems
before with patches you've submitted but this is even further off the
mark than previously.  I did start replying in detail but there's so
many really basic issues from the coding and patch submission style
level up that it was taking too long.

In general whenever you're modifying code (kernel or otherwise) if what
you're doing doesn't visually resemble the rest of the system there's
probably a problem.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/