linux-kernel - Re: [PATCH] tracing: fix event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1320111482.4793.23.camel@gandalf.stny.rr.com>
Date:	Mon, 31 Oct 2011 21:38:02 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Ilya Dryomov <idryomov@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: fix event_subsystem ref counting

On Tue, 2011-11-01 at 09:12 +0800, Li Zefan wrote:
> Steven Rostedt wrote:
> > On Mon, 2011-10-31 at 11:07 +0200, Ilya Dryomov wrote:
> >> Fix a bug introduced by e9dbfae5, which prevents event_subsystem from
> >> ever being released.
> >>
> >> Ref_count was added to keep track of subsystem users, not for counting
> >> events.  Subsystem is created with ref_count = 1, so there is no need to
> >> increment it for every event, we have nr_events for that.  Fix this by
> >> touching ref_count only when we actually have a new user -
> >> subsystem_open().
> > 
> > Good catch, I'll pull this in.
> > 
> 
> I made a different fix last week:
> 
> http://marc.info/?l=linux-kernel&m=131978486911595&w=2
> 
> but I guess Ilya's version is a bit better.

That patch was still in my queue to process, as I missed it during my
travels to Prague. But yeah, I think Ilya's patch is a better solution.

Thanks!

-- Steve



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/