linux-kernel - Re: [PATCH] config: Add 'make kvmconfig'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EB1084F.4020206@suse.cz>
Date:	Wed, 02 Nov 2011 10:07:27 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Matthias Schniedermeyer <ms@...d.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Sam Ravnborg <sam@...nborg.org>,
	Sasha Levin <levinsasha928@...il.com>,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] config: Add 'make kvmconfig'

On 2.11.2011 09:41, Ingo Molnar wrote:
> 
> * Matthias Schniedermeyer <ms@...d.de> wrote:
> 
>> And AFAICS there currently is no "modconfig", only an 
>> "allmodconfig" (and "localmodconfig")
>>
>> With no letters dropped it would be less ambiguous. make 
>> modifyconfig=kvm
> 
> Yeah. Note that it's more like an 'add' operation, not a modify 
> operation, thus:
> 
> 	make addconfig=kvm
> 
> or:
> 
> 	make addconfig kvm
> 
> would be intuitive and would work well too.
> 
> Sam, Michal, which one would you prefer? The latter might have the 
> advantage that it's additive, enabling future usages like:
> 
> 	make addconfig kvm debug

The problem is that neither of these fit into the make command syntax:

    make addconfig kvm debug

tells make to build three different targets, and

    make addconfig=kvm

tells make to create a variable named addconfig with the value kvm and
build the default target. And BTW, you or someone else reassured me
earlier in the thread that this is going to be needed for the kvm case
solely, so why are you inventing something generic now? :)

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/