[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20111102093935.GB20916@elte.hu>
Date: Wed, 2 Nov 2011 10:39:35 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Michal Marek <mmarek@...e.cz>
Cc: Matthias Schniedermeyer <ms@...d.de>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Sam Ravnborg <sam@...nborg.org>,
Sasha Levin <levinsasha928@...il.com>,
linux-kernel@...r.kernel.org,
Linus Torvalds <torvalds@...ux-foundation.org>,
Pekka Enberg <penberg@...helsinki.fi>,
linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] config: Add 'make kvmconfig'
* Michal Marek <mmarek@...e.cz> wrote:
> On 2.11.2011 10:17, Ingo Molnar wrote:
> > * Michal Marek <mmarek@...e.cz> wrote:
> >> On 2.11.2011 09:41, Ingo Molnar wrote:
> >>> Yeah. Note that it's more like an 'add' operation, not a modify
> >>> operation, thus:
> >>>
> >>> make addconfig=kvm
> >>>
> >>> or:
> >>>
> >>> make addconfig kvm
> >>>
> >>> would be intuitive and would work well too.
> >>>
> >>> Sam, Michal, which one would you prefer? The latter might have the
> >>> advantage that it's additive, enabling future usages like:
> >>>
> >>> make addconfig kvm debug
> >>
> >> The problem is that neither of these fit into the make command syntax:
> >>
> >> make addconfig kvm debug
> >>
> >> tells make to build three different targets, and
> >>
> >> make addconfig=kvm
> >>
> >> tells make to create a variable named addconfig with the value kvm
> >> and build the default target. And BTW, you or someone else
> >> reassured me earlier in the thread that this is going to be needed
> >> for the kvm case solely, so why are you inventing something generic
> >> now? :)
> >
> > Because we are trying to find *something* that is both usable and
> > which you guys are willing to ack.
> >
> > So what's your suggestion? Is 'make kvmconfig' OK?
>
> As I said, make kvmconfig is fine with me, if it's just this single case.
>
> Michal
Great, thanks!
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists