linux-kernel - Re: [PATCH v2 8/8] arm/tegra: add support for tegra30 based board cardhu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111102161919.GM13358@tbergstrom-lnx.Nvidia.com>
Date:	Wed, 2 Nov 2011 18:19:19 +0200
From:	Peter De Schrijver <pdeschrijver@...dia.com>
To:	Stephen Warren <swarren@...dia.com>
CC:	Russell King <linux@....linux.org.uk>,
	Colin Cross <ccross@...roid.com>,
	Olof Johansson <olof@...om.net>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH v2 8/8] arm/tegra: add support for tegra30 based board
 cardhu

On Wed, Nov 02, 2011 at 05:07:52PM +0100, Stephen Warren wrote:
> Peter De Schrijver wrote at Wednesday, November 02, 2011 9:46 AM:
> > On Wed, Nov 02, 2011 at 03:09:07PM +0100, Peter De Schrijver wrote:
> > > Add support for the tegra30 based cardhu development board. Cardhu is a tablet
> > > formfactor reference design for tegra30. The patch provides a device tree for
> > > the board, updates Makefile.boot to build the dtb, includes the platform in
> > > Kconfig and updates board-dt.c.
> ...
> > > diff --git a/arch/arm/boot/dts/tegra-cardhu.dts b/arch/arm/boot/dts/tegra-cardhu.dts
> > > new file mode 100644
> > > index 0000000..70c41fc
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/tegra-cardhu.dts
> > > @@ -0,0 +1,36 @@
> > > +/dts-v1/;
> > > +
> > > +/include/ "tegra30.dtsi"
> > > +
> > > +/ {
> > > +	model = "NVIDIA Tegra30 Cardhu evaluation board";
> > 
> > And this should probably be removed.
> 
> I don't follow the reasoning here; it seems correct to identify what this
> .dts file applies to, and having a model property is consistent with other
> .dts files, including non-Tegra boards.

hmm :) Based on your comments on the previous version, I thought you wanted
to move this do a different patch which also does it for other boards.

Cheers,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/