linux-kernel - Re: [PATCH] genirq: spurious.c: fix regression that broke irqfixup,irqpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1111021901440.2829@ionos>
Date:	Wed, 2 Nov 2011 19:02:35 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	edward.donovan@...ble.net
cc:	linux-kernel@...r.kernel.org, maciej.rutecki@...il.com
Subject: Re: [PATCH] genirq: spurious.c: fix regression that broke
 irqfixup,irqpoll

On Tue, 1 Nov 2011, edward.donovan@...ble.net wrote:

> From: Edward Donovan <edward.donovan@...ble.net>
> 
> commit  d05c65fff0 ("genirq: spurious: Run only one poller at a time")
> introduced a regression, leaving the boot options 'irqfixup' and
> 'irqpoll' non-functional.  The patch placed tests in each function, to
> exit if the function is already running.  The test in 'misrouted_irq'
> exited when it should have proceeded, effectively disabling
> 'misrouted_irq' and 'poll_spurious_irqs'.  Reversing the "==" operator
> to "!=" fixes the regression.
> 
> Signed-off-by: Edward Donovan <edward.donovan@...ble.net>

Good catch! I was staring at it with my conference and flu damaged
brain ....

Thanks,

	tglx

> ---
>  kernel/irq/spurious.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
> index aa57d5d..b5f4742 100644
> --- a/kernel/irq/spurious.c
> +++ b/kernel/irq/spurious.c
> @@ -115,7 +115,7 @@ static int misrouted_irq(int irq)
>  	struct irq_desc *desc;
>  	int i, ok = 0;
>  
> -	if (atomic_inc_return(&irq_poll_active) == 1)
> +	if (atomic_inc_return(&irq_poll_active) != 1)
>  		goto out;
>  
>  	irq_poll_cpu = smp_processor_id();
> -- 
> 1.7.5.4
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/