linux-kernel - Re: [PATCH 3/7] drm/i915: Treat PCH eDP like DP in most places

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_O82QYfK9Dh+Rb41Ranstok+RSAg4UxY+6gDXeXTeu0Mw@mail.gmail.com>
Date:	Wed, 2 Nov 2011 15:07:57 -0400
From:	Alex Deucher <alexdeucher@...il.com>
To:	Keith Packard <keithp@...thp.com>
Cc:	intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 3/7] drm/i915: Treat PCH eDP like DP in most places

On Wed, Nov 2, 2011 at 2:54 PM, Keith Packard <keithp@...thp.com> wrote:
> On Tue,  1 Nov 2011 23:20:26 -0700, Keith Packard <keithp@...thp.com> wrote:
>
>>               intel_dp = enc_to_intel_dp(encoder);
>> -             if (intel_dp->base.type == INTEL_OUTPUT_DISPLAYPORT) {
>> +             if (intel_dp->base.type == INTEL_OUTPUT_DISPLAYPORT || is_pch_edp(intel_dp)) {
>>                       lane_count = intel_dp->lane_count;
>>                       break;
>> -             } else if (is_edp(intel_dp)) {
>> +             } else if (is_cpu_edp(intel_dp)) {
>>                       lane_count = dev_priv->edp.lanes;
>>                       break;
>
> Thinking about this one more time -- if we ever want to use
> dev_priv->edp.lanes, we should use it in
> intel_dp_max_lane_count. intel_dp_set_m_n should use
> intel_dp->lane_count unconditionally as that's the value we've used
> everywhere else for mode setting.
>
> Perhaps we should use it for monitors that don't include the
> MAX_LANE_COUNT field in the dpcd? Perhaps we should use it on all eDP
> monitors?

FWIW, we rely on the DPCD field for eDP just like DP.  Our vbios LCD
tables don't contain DP lane or rate info.

Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/