linux-kernel - Re: [PATCH] Stageing: bcm: fixed spacing coding style in led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1320202495.15779.11.camel@Joe-Laptop>
Date:	Wed, 02 Nov 2011 04:54:55 +0200
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Paul Bolle <pebolle@...cali.nl>, devel@...verdev.osuosl.org,
	Ciaran McCormick <ciaranmccormick@...il.com>, gregkh@...e.de,
	shemminger@...tta.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Stageing: bcm: fixed spacing coding style in
 led_control.c

On Tue, 2011-11-01 at 23:22 +0300, Dan Carpenter wrote:
> You're right that this driver needs a lot of work.
[]
> I'd prefer a series of patches:

Thanks Dan, that's a good summary of useful changes
and their best order.  Couple of comments:

> [patch 1/3] Staging: bcm: fix whitespace in led_control.c
> This would address tabs vs spaces, extra prohibited spaces, and
> spaces required around certain chars.  Also it would add blank lines
> between functions and between declarations and code.

And verify with git diff -w and object diffs.

> [patch 2/3] Staging: bcm: fix C99 comments in led_control.c
> This would fix the 74 ERROR: do not use C99 // comments
> 
> [patch 3/3] Staging: bcm: fix braces style in led_control.c
> This would fix the 70 ERROR: that open brace { should be on the
> previous line.

I'd combine this whitespace change with 1/x myself.

> [patch 1/y] Staging: bcm: Rename "Status" to "ret" in led_control.c
> [patch 2/y] Staging: bcm: Rename CamelCase variables in led_control.c

Dan's rename_review script can help verify this as well.
https://lkml.org/lkml/2011/7/19/196

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/