linux-kernel - Re: [PATCH] arm/tegra: add support for tegra30 interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111102204006.GA14564@legolas.emea.dhcp.ti.com>
Date:	Wed, 2 Nov 2011 22:40:07 +0200
From:	Felipe Balbi <balbi@...com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Felipe Balbi <balbi@...com>, Nicolas Pitre <nico@...xnic.net>,
	Stephen Warren <swarren@...dia.com>,
	Peter De Schrijver <pdeschrijver@...dia.com>,
	Colin Cross <ccross@...roid.com>,
	Olof Johansson <olof@...om.net>, Gary King <gking@...dia.com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm/tegra: add support for tegra30 interrupts

Hi,

On Wed, Nov 02, 2011 at 07:54:04PM +0000, Russell King - ARM Linux wrote:
> On Wed, Nov 02, 2011 at 09:48:28PM +0200, Felipe Balbi wrote:
> > Hi,
> > 
> > you forgot to comment on the fact that gpio_desc shouldn't be held in an
> > array. Any comments ?
> 
> I did not comment on that because that's someone elses problem.

fair enough.

> > What I mean is that, just like irq_descs, we should be able to allocate
> > them dynamically. Maybe, just like irq_descs, hold them in a radix tree
> > and maybe even have a matching API "gpio_alloc_descs()".
> 
> Probably - I expect Grant would really like to see some patches along
> those lines.  As I say, someone elses problem.
> 
> But what is _our_ problem is what to do with all the ARCH_NR_GPIOs
> that we have now, and stop them increasing.  There is a trivial solution
> to that which I outlined which can be used until GPIO gets something
> along your idea - and which doesn't involve me having to argue with
> those who think that the kernel should remain as small as possible.

k, I'll see if I can cook something up.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)