linux-kernel - Re: [PATCH] pciehp: Retrieve link speed after link is trained

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111102140522.411ef343@jbarnes-desktop>
Date:	Wed, 2 Nov 2011 14:05:22 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Yinghai Lu <yinghai.lu@...cle.com>
Cc:	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Subject: Re: [PATCH] pciehp: Retrieve link speed after link is trained

On Sun, 09 Oct 2011 00:06:06 -0700
Yinghai Lu <yinghai.lu@...cle.com> wrote:

> 
> During hot plug, board_added will call pciehp_power_on_slot().
> But link speed is updated in pciehp_power_on_slot().
> 
> We should not update link speed there, because that is too early.
> 
> Move updating to pciehp_check_link_status() after making sure link is trained.
> 
> Signed-off-by: Yinghai Lu <yinghai.lu@...cle.com>
> 
> ---
>  drivers/pci/hotplug/pciehp_hpc.c |   10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> Index: linux-2.6/drivers/pci/hotplug/pciehp_hpc.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/hotplug/pciehp_hpc.c
> +++ linux-2.6/drivers/pci/hotplug/pciehp_hpc.c
> @@ -294,6 +294,8 @@ int pciehp_check_link_status(struct cont
>  		return retval;
>  	}
>  
> +	pcie_update_link_speed(ctrl->pcie->port->subordinate, lnk_status);
> +
>  	return retval;
>  }
>  
> @@ -516,14 +518,6 @@ int pciehp_power_on_slot(struct slot * s
>  	ctrl_dbg(ctrl, "%s: SLOTCTRL %x write cmd %x\n", __func__,
>  		 pci_pcie_cap(ctrl->pcie->port) + PCI_EXP_SLTCTL, slot_cmd);
>  
> -	retval = pciehp_readw(ctrl, PCI_EXP_LNKSTA, &lnk_status);
> -	if (retval) {
> -		ctrl_err(ctrl, "%s: Cannot read LNKSTA register\n",
> -				__func__);
> -		return retval;
> -	}
> -	pcie_update_link_speed(ctrl->pcie->port->subordinate, lnk_status);
> -
>  	return retval;
>  }

Kenji-san or Hidetoshi-san, would it be possible to get tested-bys and
reviewed-bys from you on this patch?

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)