linux-kernel - RE: [PATCH] i2c-gpio.c: correct logic of pdata->scl_is_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <EF2E73589CA71846A15D0B2CDF79505D087B34C115@wm021.weinmann.com>
Date:	Wed, 2 Nov 2011 06:56:50 +0100
From:	"Voss, Nikolaus" <N.Voss@...nmann.de>
To:	"'H Hartley Sweeten'" <hartleys@...ionengravers.com>,
	'Håvard Skinnemoen' <hskinnemoen@...il.com>
CC:	"'Linux Kernel'" <linux-kernel@...r.kernel.org>,
	"'linux-arm-kernel@...ts.infradead.org'" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH] i2c-gpio.c: correct logic of pdata->scl_is_open_drain

> If the "is_open_drain" flags are not set, the I2C bus works correctly
> regardless of the existence of the pull-ups.

No, I2C can only work with anything pulling up SDA weakly, usually an
external pullup. This is independent of the "is_open_drain" property
which only describes how the driver internally accomplishes the high
impedance state.

SCL can be driven push-pull ("scl_is_output_only") but will not be
I2C-compliant any more (no clock stretching), and only clients not relying
on that feature will work.

Niko

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/