linux-kernel - Re: REGRESSION: "perf: Add PM notifiers ..." breaks resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwCf41GFOVA656-ZgZB5mBNkpH3KqRfJ_Ornkn3RWF5gQ@mail.gmail.com>
Date:	Wed, 2 Nov 2011 17:00:29 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>, mingo@...e.hu,
	linux-kernel@...r.kernel.org, rjw@...k.pl
Subject: Re: REGRESSION: "perf: Add PM notifiers ..." breaks resume

Peter, Ingo, ping?

Quite frankly, I'm inclined to revert that patch just for being
horribly ugly and apparently broken regardless of the fact that it
also causes a regression.

*Notifiers* for doing something like this? smp_call_function? That's
just utter sh*t, guys.

If it is CPU state, then it should damn well be suspended and resumed
as part of CPU suspend and resume. No IPI cross-calls to ask other
CPU's to do random work, no crap like that.

Comments? Should I just revert the thing (silence is obviously "yes"
in cases like this where we are talking about regressions anyway)?

                   Linus

On Wed, Nov 2, 2011 at 6:49 AM, Andi Kleen <andi@...stfloor.org> wrote:
>
> Resume stopped working on my Acer Aspire 1830T post 3.1. The screen
> just stays black after wakeup.
>
> I bisected it down to
>
> commit 144060fee07e9c22e179d00819c83c86fbcbf82c
> Author: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Date:   Mon Aug 1 12:49:14 2011 +0200
>
>    perf: Add PM notifiers to fix CPU hotplug races
>
> Reverting this patch fixes the problem for me.
>
> -Andi
>
> --
> ak@...ux.intel.com -- Speaking for myself only.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/