linux-kernel - Re: [PATCH] clocksource: Avoid selecting mult values that might overflow when adjusted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1320325819.2892.1.camel@js-netbook>
Date:	Thu, 03 Nov 2011 09:10:19 -0400
From:	John Stultz <john.stultz@...aro.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Yong Zhang <yong.zhang0@...il.com>,
	David Daney <ddaney.cavm@...il.com>
Subject: Re: [PATCH] clocksource: Avoid selecting mult values that might
 overflow when adjusted

On Thu, 2011-11-03 at 13:05 +0100, Thomas Gleixner wrote:
> On Wed, 2 Nov 2011, John Stultz wrote:
> >  
> > +	WARN_ONCE(timekeeper.mult+adj >
> > +			timekeeper.clock->mult + timekeeper.clock->maxadj,
> > +			"Adjusting more then 11%%");
> 
> Shouldn't we rather limit the update instead of just warn and overflow ?

Well, I'm hesitant to commit to that, just yet. So I figured I'd start
with the warning.

thanks
-john


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/