linux-kernel - Re: [PATCH v3 4/6] mfd: TPS65910: Move linux/gpio.h include to header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111103172511.GC30472@legolas.emea.dhcp.ti.com>
Date:	Thu, 3 Nov 2011 19:25:12 +0200
From:	Felipe Balbi <balbi@...com>
To:	Kyle Manna <kyle.manna@...l7.com>
Cc:	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH v3 4/6] mfd: TPS65910: Move linux/gpio.h include to header

Hi,

On Thu, Nov 03, 2011 at 12:08:04PM -0500, Kyle Manna wrote:
> The tps65910.h file depends on linux/gpio.h.  Move the include from the
> source file to the tps65910.h header file.

you should never rely on indirect inclusion of header files. If both
header and C source need the header, include on both. The header should
be safe for multiple inclusions anyway.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)