[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAKWjMd5pDvHKVJeEBhT12bH8C7Q=7TuaFtBNuij-4YRGMrjtdA@mail.gmail.com>
Date: Thu, 3 Nov 2011 17:46:15 -0500
From: Andy Fleming <afleming@...il.com>
To: Kyle Moffett <Kyle.D.Moffett@...ing.com>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
"David S. Miller" <davem@...an.davemloft.net>,
Greg Dietsche <Gregory.Dietsche@....edu>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
David Daney <ddaney@...iumnetworks.com>,
Arnaud Patard <arnaud.patard@...-net.org>,
Grant Likely <grant.likely@...retlab.ca>,
Baruch Siach <baruch@...s.co.il>,
Stephen Hemminger <shemminger@...tta.com>,
Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
Marc Kleine-Budde <mkl@...gutronix.de>,
Andrew Morton <akpm@...ux-foundation.org>,
Mike Frysinger <vapier@...too.org>
Subject: Re: [RFC PATCH 06/17] phy_driver: Add and use phy_driver_[un]register_multiple()
On Thu, Oct 20, 2011 at 4:00 PM, Kyle Moffett <Kyle.D.Moffett@...ing.com> wrote:
> Several of the PHY drivers are registering dozens of "phy_driver"
> structures at load-time, with different IDs and variations on methods.
> As a result, the error handling is exceptionally ugly.
>
> The "marvell" driver already uses an array of "struct phy_driver" and
> iterates over that to add the drivers, but even then its error handling
> contains a bug (it will not unregister array item 0 on failure).
>
> To resolve these problems, new functions phy_driver_register_multiple()
> and phy_driver_unregister_multiple() are added which take an array and a
> number of drivers and iterate over them internally.
>
> All of the PHY driver files which register more than one "phy_driver"
> are modified to use the new helpers. This is a sizable net removal of
> about 260 lines of code.
>
> Signed-off-by: Kyle Moffett <Kyle.D.Moffett@...ing.com>
Let's try that again, sending to the list.
This is excellent!
Very much
Acked-by: Andy Fleming <afleming@...escale.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists