linux-kernel - Re: Incorrect checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGxe1ZFxE+ktigoTQjsCx8AYJbSfT+FDa9ms4Y=d8P96enzxSA@mail.gmail.com>
Date:	Fri, 4 Nov 2011 06:23:49 -0400
From:	Girish K S <girish.shivananjappa@...aro.org>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	joe@...ches.com, linux-kernel@...r.kernel.org,
	linux-mmc <linux-mmc@...r.kernel.org>
Subject: Re: Incorrect checkpatch warning

On 4 November 2011 04:00, Adrian Hunter <adrian.hunter@...el.com> wrote:
> Hi
>
> This checkpatch warning looks wrong:
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #73: FILE: drivers/mmc/host/sdhci-pci-data.c:5:
> +EXPORT_SYMBOL_GPL(sdhci_pci_get_data);
>
> The patch has this:
>
> diff --git a/drivers/mmc/host/sdhci-pci-data.c b/drivers/mmc/host/sdhci-pci-data.c
> new file mode 100644
> index 0000000..a611217
> --- /dev/null
> +++ b/drivers/mmc/host/sdhci-pci-data.c
> @@ -0,0 +1,5 @@
> +#include <linux/module.h>
> +#include <linux/mmc/sdhci-pci-data.h>
> +
> +struct sdhci_pci_data *(*sdhci_pci_get_data)(struct pci_dev *pdev, int slotno);
> +EXPORT_SYMBOL_GPL(sdhci_pci_get_data);
>since it is a prototype you get that message. use EXPORT_SYMBOL below the function definition and not below prototype declaration
>
> Regards
> Adrian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/