lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4EB3C642.5040304@ge.com>
Date:	Fri, 04 Nov 2011 11:02:26 +0000
From:	Martyn Welch <martyn.welch@...com>
To:	Manohar Vanga <manohar.vanga@...n.ch>
CC:	gregkh@...e.de, cota@...ap.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: vme: fix comment in __vme_register_driver()

On 04/11/11 10:12, Manohar Vanga wrote:
> Signed-off-by: Manohar Vanga <manohar.vanga@...n.ch>

Acked-by: Martyn Welch <martyn.welch@...com>

> ---
>  drivers/staging/vme/vme.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
> index b04b468..3cbc69c 100644
> --- a/drivers/staging/vme/vme.c
> +++ b/drivers/staging/vme/vme.c
> @@ -1421,10 +1421,7 @@ static int __vme_register_driver(struct vme_driver *drv, unsigned int ndevs)
>  		 * and if the bridge is removed, it will have to go through
>  		 * vme_unregister_bridge() to do it (which calls remove() on
>  		 * the bridge which in turn tries to acquire vme_buses_lock and
> -		 * will have to wait). The probe() called after device
> -		 * registration in __vme_register_driver below will also fail
> -		 * as the bridge is being removed (since the probe() calls
> -		 * vme_bridge_get()).
> +		 * will have to wait).
>  		 */
>  		err = __vme_register_driver_bus(drv, bridge, ndevs);
>  		if (err)


-- 
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms                   | Wales (3828642) at 100
T +44(0)1327322748                         | Barbirolli Square, Manchester,
E martyn.welch@...com                      | M2 3AB  VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ