linux-kernel - Re: [GIT] Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EB41BC5.4010304@candelatech.com>
Date:	Fri, 04 Nov 2011 10:07:17 -0700
From:	Ben Greear <greearb@...delatech.com>
To:	Johannes Berg <johannes@...solutions.net>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>,
	"Guy, Wey-Yi W" <wey-yi.w.guy@...el.com>,
	"John W. Linville" <linville@...driver.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Stanislaw Gruszka <sgruszka@...hat.com>
Subject: Re: [GIT] Networking

On 11/04/2011 10:03 AM, Johannes Berg wrote:
> On Tue, 2011-10-25 at 12:26 +0000, Linus Torvalds wrote:
>> On Tue, Oct 25, 2011 at 12:32 PM, David Miller<davem@...emloft.net>  wrote:
>>>
>>> The most visible thing in here is the reorganization of the drivers
>>> under drivers/net.
>>
>> Nope, the most visible thing are some new annoying warnings, that seem
>> absolutely broken.
>>
>> At the very minimum, that WARN_ON(1) should be a WARN_ON_ONCE() or
>> something like that. Because showing it over an dover again is not
>> helpful.
>>
>> Added the people who signed off on the changes to the affected files,
>> since they hopefully know why this happens and can fix it..
>
> Sorry for the late reply.
>
> I think this was actually caused by some changes from Ben Greear
> "optimising" stuff in net/mac80211/work.c and keeping the wrong channel,
> Stanislaw was also looking at this at some point I think. I agree that
> it would be good to change to WARN_ON_ONCE(), will do that.
>
> The warning itself has been around forever, but the fact that it
> triggers now is probably related to the channel work&  band switches.

There are patches for the work_work bugs I introduced, and they
are in wireless-testing, and were CC'd to stable as far as I
can tell.

Thanks,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/