linux-kernel - Re: [PATCH] clocksource: Avoid selecting mult values that might overflow when adjusted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111104021629.GA14139@zhy>
Date:	Fri, 4 Nov 2011 10:16:29 +0800
From:	Yong Zhang <yong.zhang0@...il.com>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	John Stultz <john.stultz@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Daney <ddaney.cavm@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] clocksource: Avoid selecting mult values that might
 overflow when adjusted

On Thu, Nov 03, 2011 at 05:36:49PM +0800, Américo Wang wrote:
> On Thu, Nov 3, 2011 at 11:10 AM, Yong Zhang <yong.zhang0@...il.com> wrote:
> > On Wed, Nov 02, 2011 at 01:01:27PM -0700, John Stultz wrote:
> >> +     WARN_ONCE(timekeeper.mult+adj >
> >> +                     timekeeper.clock->mult + timekeeper.clock->maxadj,
> >> +                     "Adjusting more then 11%%");
> >
> >                        s/then/than ; s/%%/%\n ?
> 
>        %      A '%' is written.  No argument is converted.  The
> complete conversion specification is '%%'.

Oh, thanks for pointing it out. But my point is just we need '\n' in
the end.

Thanks,
Yong
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/