linux-kernel - Re: [RESEND 3/3] coccicheck: add parallel execution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1111061920060.1873@hadrien>
Date:	Sun, 6 Nov 2011 19:20:26 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Greg Dietsche <Gregory.Dietsche@....edu>
cc:	julia@...u.dk, Gilles.Muller@...6.fr, npalix.work@...il.com,
	mmarek@...e.cz, rdunlap@...otime.net, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, cocci@...u.dk
Subject: Re: [RESEND 3/3] coccicheck: add parallel execution

On Sat, 5 Nov 2011, Gregory.Dietsche@....edu wrote:

> From: Greg Dietsche <Gregory.Dietsche@....edu>
>
> For example to process 6 SmPL patches at the same time:
> 	make coccicheck PARALLEL=6
>
> Results are held in /tmp until the scripts finish. By doing this the
> script is able to collate the results from each SmPL patch instead of
> interleaving them in the output.
>
> Version 2: change pkill -P $$ to pkill -s 0
>
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@....edu>
> Acked-by: Nicolas Palix <npalix.work@...il.com>

Acked-by: Julia Lawall <julia.lawall@...6.fr>

> ---
> scripts/coccicheck |   27 ++++++++++++++++++++++++++-
> 1 files changed, 26 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index 1bb1a1b..c2a04c2 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -97,10 +97,35 @@ coccinelle () {
>
> }
>
> +parallel_cleanup () {
> +	pkill -s 0 > /dev/null
> +	rm /tmp/cocci_parallel_$$_* 2>/dev/null
> +	exit
> +}
> +
> +trap parallel_cleanup SIGINT
> +PARALLEL_ID=0
> +
> if [ "$COCCI" = "" ] ; then
>     for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> -	coccinelle $f
> +	if [ "$PARALLEL" -eq "$PARALLEL" 2>/dev/null ] ; then
> +		if [ "$ONLINE" = "0" ] ; then
> +			echo Processing: `basename $f`
> +		fi
> +		coccinelle $f>/tmp/cocci_parallel_$$_$PARALLEL_ID 2>&1 &
> +		PARALLEL_ID=$(($PARALLEL_ID + 1))
> +		while [ "`jobs -p | wc -l`" -ge "$PARALLEL" ] ; do
> +			sleep 3
> +		done
> +	else
> +		coccinelle $f
> +	fi
>     done
> +    wait
> +    if [ "$PARALLEL_ID" -ge "0" ] ; then
> +	cat /tmp/cocci_parallel_$$_*
> +	parallel_cleanup
> +    fi
> else
>     coccinelle $COCCI
> fi
> -- 
> 1.7.6.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/