linux-kernel - Re: [PATCH 1/2] gpiolib: output basic details and consolidate gpio device drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111106183336.GA2546@ponder.secretlab.ca>
Date:	Sun, 6 Nov 2011 11:33:36 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Hartmut Knaack <knaack.h@....de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] gpiolib: output basic details and consolidate gpio
 device drivers

On Sat, Nov 05, 2011 at 10:27:51PM +0100, Hartmut Knaack wrote:
> This patch adds a kernel message, containing GPIO range and device name on successful device registration.
> 
> Signed-off-by: Hartmut Knaack <knaack.h@....de>
> -------------------------------------------------------------

For next time; the divider between commit text and patch must be
exactly 3 '-' characters long, no more, no less.  Otherwise the tools
don't handle it properly.

> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index a971e3d..d919ac6 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1088,6 +1088,10 @@ unlock:
>  	status = gpiochip_export(chip);
>  	if (status)
>  		goto fail;
> +	

Whitespace error.

Otherwise looks good.  I'm picking it up and squashing it together
with the second patch.

> +	pr_info("gpiochip_add: registered GPIOs %d to %d on device: %s\n",
> +		chip->base, chip->base + chip->ngpio - 1,
> +		chip->label ? : "generic");
>  
>  	return 0;
>  fail:
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/